Add more integration tests #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianchu
approved these changes
Aug 21, 2020
agocs
approved these changes
Aug 21, 2020
Contributor
agocs
left a comment
agocs
left a comment
There was a problem hiding this comment.
This is good. My one concern is adding an external dependency on stat.us being up in order for our tests to pass. Might be worth adding a note to the run_integration_tests.sh to remind future-us to check stat.us if tests fail.
Contributor
Author
|
Added a comment on the failure of the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new lambda function to get tested (http-errors) and an additional serverless framework configuration (using the serverless-plugin-datadog) to improve coverage.
Since the serverless-plugin-datadog by default uses the latest version of the datadog-lambda-js library, I used addLayers false and included the local build of the library in the serverless build.
I noticed that some log lines are not in order so I sorted them before comparing to improve flakiness.
Motivation
A ticket https://datadoghq.atlassian.net/browse/SLS-471
Coverage
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply